diff options
author | Tavian Barnes <tavianator@tavianator.com> | 2024-03-07 16:18:32 -0500 |
---|---|---|
committer | Tavian Barnes <tavianator@tavianator.com> | 2024-03-07 16:26:25 -0500 |
commit | 43cd776d7dc8ac573262f8459edeb1c1f5f3cd09 (patch) | |
tree | 4aae15ba3afb55506e43faf3dd36076f504fb793 /src/eval.c | |
parent | 416ca3b557055efa5746a4d40d927391c59a9292 (diff) | |
download | bfs-43cd776d7dc8ac573262f8459edeb1c1f5f3cd09.tar.xz |
xtime: Call tzset() from main() instead of lazily
POSIX specifies[1] that
If a thread accesses tzname, daylight, or timezone directly while
another thread is in a call to tzset(), or to any function that is
required or allowed to set timezone information as if by calling
tzset(), the behavior is undefined.
So calling it lazily from arbitrary threads is risky.
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/tzset.html
Diffstat (limited to 'src/eval.c')
-rw-r--r-- | src/eval.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -730,7 +730,7 @@ bool eval_fls(const struct bfs_expr *expr, struct bfs_eval *state) { time_t six_months_ago = now - 6 * 30 * 24 * 60 * 60; time_t tomorrow = now + 24 * 60 * 60; struct tm tm; - if (xlocaltime(&time, &tm) != 0) { + if (!localtime_r(&time, &tm)) { goto error; } char time_str[256]; |