Unify broken symlink handling

Rather than open-code the fallback logic for broken symlinks everywhere
it's needed, introduce a new xfstatat() utility function that performs
the fallback automatically.

Using xfstatat() consistently fixes a few bugs, including cases where
broken symlinks are given as arguments to predicates like -samefile.

1 files changed, 1 insertions, 1 deletions

diff --git a/parse.c b/parse.c
index 2ba0602..ef252fb 100644
--- a/parse.c
+++ b/parse.c
@@ -345,7 +345,7 @@ static int stat_arg(const struct parser_state *state, struct expr *expr, struct
 	bool follow = cmdline->flags & (BFTW_COMFOLLOW | BFTW_LOGICAL);
 	int flags = follow ? 0 : AT_SYMLINK_NOFOLLOW;
 
-	int ret = fstatat(AT_FDCWD, expr->sdata, sb, flags);
+	int ret = xfstatat(AT_FDCWD, expr->sdata, sb, &flags);
 	if (ret != 0) {
 		cfprintf(cmdline->cerr, "%{er}error: '%s': %s%{rs}\n", expr->sdata, strerror(errno));
 	}